lianetm commented on code in PR #14912:
URL: https://github.com/apache/kafka/pull/14912#discussion_r1416580989


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -388,11 +385,13 @@ private CompletableFuture<ListOffsetResult> 
buildListOffsetRequestToNode(
      * {@link 
org.apache.kafka.clients.consumer.internals.NetworkClientDelegate.UnsentRequest}
      * that can be polled to obtain the corresponding timestamps and offsets.
      */
-    private List<NetworkClientDelegate.UnsentRequest> 
buildListOffsetsRequestsAndResetPositions(
+    private CompletableFuture<Void> sendListOffsetsRequestsAndResetPositions(

Review Comment:
   Let's update the description about the return value that changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to