kamalcph commented on PR #14905: URL: https://github.com/apache/kafka/pull/14905#issuecomment-1842245405
> Does that mean currently, when the log start offset incremented over the candidate segments, we won't delete until the segments are uploaded to the remote storage? The local-log segments won't be eligible for deletion and they are not eligible for upload to remote storage as well since the log-start-offset might already be moved. Once the next-set of segments gets uploaded, then the `highest-copied-remote-offset` will be higher than not-uploaded local-log segments, then they became eligible for deletion. This patch is raised to address edge cases where the topic becomes stale/deprecated post the log-start-offset update. > If so, does that mean those uploaded segments will be deleted next time when when enter `cleanupExpiredRemoteLogSegments` because of `isSegmentBreachByLogStartOffset`? Yes, correct. The uploaded remote segments will be cleaned up by `cleanupExpiredRemoteLogSegments` due to `isSegmentBreachByLogStartOffset`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
