apoorvmittal10 commented on code in PR #14946:
URL: https://github.com/apache/kafka/pull/14946#discussion_r1417815612
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -321,6 +332,9 @@ public void
onHeartbeatResponseReceived(ConsumerGroupHeartbeatResponseData respo
this.memberEpoch = response.memberEpoch();
ConsumerGroupHeartbeatResponseData.Assignment assignment =
response.assignment();
+ clientTelemetryReporter.ifPresent(reporter ->
reporter.updateMetricsLabels(
+ Collections.singletonMap(ClientTelemetryProvider.GROUP_MEMBER_ID,
memberId)));
Review Comment:
Yeah, I needed that feedback and that's the reason I saw multiple updates
happening for labels and optimized duplicate labels.
However I think handling duplicates was anyways required but let me check
what should be the right place where this update should be called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
