kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1419463055
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -180,12 +179,12 @@ private void process(final ListOffsetsApplicationEvent
event) {
* consumer join the group if it is not part of it yet, or send the
updated subscription if
* it is already a member.
*/
- private void process(final SubscriptionChangeApplicationEvent event) {
- if (!requestManagers.membershipManager.isPresent()) {
- throw new RuntimeException("Group membership manager not present
when processing a " +
- "subscribe event");
+ private void process(final SubscriptionChangeApplicationEvent ignored) {
+ if (!requestManagers.heartbeatRequestManager.isPresent()) {
Review Comment:
I'm being a bit of a stickler here, but `RequestManagers` is designed to
hold instances of `RequestManager`s, not be a holder for arbitrary objects that
might be useful.
I can add the `MembershipManager` instance directly to the
`ApplicationEventProcessor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
