cmccabe commented on code in PR #14863:
URL: https://github.com/apache/kafka/pull/14863#discussion_r1419522832


##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -2016,6 +2021,70 @@ ListPartitionReassignmentsResponseData 
listPartitionReassignments(
         return response;
     }
 
+    ControllerResult<AssignReplicasToDirsResponseData> 
handleAssignReplicasToDirs(AssignReplicasToDirsRequestData request) {

Review Comment:
   For future reference, we shouldn't check MV in ControllerApis, but in 
`ReplicationControlManager`. `handleDescribeCluster` does something different 
because it's consulting a cache



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to