philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1420817920
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -587,6 +599,18 @@ public boolean shouldSkipHeartbeat() {
return state == MemberState.UNSUBSCRIBED || state == MemberState.FATAL;
}
+ /**
+ * {@inheritDoc}
+ */
+ @Override
+ public void transitionToStaled() {
+ transitionTo(MemberState.PREPARE_LEAVING);
+ memberEpoch = ConsumerGroupHeartbeatRequest.LEAVE_GROUP_MEMBER_EPOCH;
+ transitionTo(MemberState.LEAVING);
+ leaveGroupInProgress =
Optional.of(CompletableFuture.completedFuture(null));
+ transitionTo(MemberState.STALED);
Review Comment:
I think transitionToJoining, which takes place when sending out the
heartbeat, already clears the current assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
