vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1848322802
> Thanks @vamossagar12, I've given the functional changes another pass. Unless I'm mistaken about the semantics for `CompletableFuture::thenAccept`, there's a pretty serious bug in the current implementation that needs to be fixed before merging, and we should also make sure to add testing coverage to both verify that we've fixed that bug now and won't re-introduce it later. Thanks @C0urante . When you say serious bug, I am assuming you are referring to this comment [here](https://github.com/apache/kafka/pull/13801#discussion_r1417751374)? That is the outer get doesn't block on the lambda's execution? Ok, let me verify that behaviour again and revert. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
