jolshan commented on PR #14599: URL: https://github.com/apache/kafka/pull/14599#issuecomment-1851104746
At first I was confused since the original PR had https://github.com/apache/kafka/blob/2a5fbf28820ddcde5ead605e070391059d5d2e18/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L200 but on closer inspection (the debugger) I see that the future is actually InvalidTopicException and that this test is wrong. I'm trying to think if there was any rationale for this decision, but after spending 20 minutes or so looking through my notes and old messages I couldn't find one. The only other concern would be compatibility, but given that the unknown topic ID error is being returned by the server, but the Cluster API doesn't know how to handle it I think this change makes sense. @ijuma do you have any concerns from the compatibility angle? Given this is an admin API, I don't think changing this error should break anything in a crazy way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
