dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424349887


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -581,6 +591,12 @@ class CoordinatorWriteEvent<T> implements 
CoordinatorEvent, DeferredEvent {
          */
         final CompletableFuture<T> future;
 
+        /**
+         * Timeout value for the write operation
+         */
+

Review Comment:
   nit: Remove empty line.



##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -581,6 +591,12 @@ class CoordinatorWriteEvent<T> implements 
CoordinatorEvent, DeferredEvent {
          */
         final CompletableFuture<T> future;
 
+        /**
+         * Timeout value for the write operation
+         */
+
+        final Duration timeout;

Review Comment:
   Should it be `defaultWriteTimeout` too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to