dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1425242119
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -997,7 +997,7 @@ public void testScheduleWriteOpWhenWriteTimesOut() throws
InterruptedException {
CompletableFuture<String> timedOutWrite =
runtime.scheduleWriteOperation("write#1", TP, Duration.ofMillis(3),
state -> new CoordinatorResult<>(Arrays.asList("record1",
"record2"), "response1"));
- timer.advanceClock(DEFAULT_WRITE_TIMEOUT.toMillis() + 1);
+ timer.advanceClock(DEFAULT_WRITE_TIMEOUT.toMillis() + 3);
Review Comment:
nit: This should be `3 + 1`.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -997,7 +997,7 @@ public void testScheduleWriteOpWhenWriteTimesOut() throws
InterruptedException {
CompletableFuture<String> timedOutWrite =
runtime.scheduleWriteOperation("write#1", TP, Duration.ofMillis(3),
state -> new CoordinatorResult<>(Arrays.asList("record1",
"record2"), "response1"));
- timer.advanceClock(DEFAULT_WRITE_TIMEOUT.toMillis() + 1);
+ timer.advanceClock(DEFAULT_WRITE_TIMEOUT.toMillis() + 3);
Review Comment:
nit: This should be `3 + 1`, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
