rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425955291
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
- // 3.7-IV0 is the latest production version in the 3.7 line
- assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+ // 3.7-IV2 is the latest production version in the 3.7 line
+ assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
assertEquals(IBP_3_7_IV0,
MetadataVersion.fromVersionString("3.7-IV0"));
assertEquals(IBP_3_7_IV1,
MetadataVersion.fromVersionString("3.7-IV1"));
assertEquals(IBP_3_7_IV2,
MetadataVersion.fromVersionString("3.7-IV2"));
- assertEquals(IBP_3_7_IV3,
MetadataVersion.fromVersionString("3.7-IV3"));
Review Comment:
Keep it?
##########
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##########
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
MetadataVersion.IBP_3_7_IV0,
MetadataVersion.IBP_3_7_IV1,
MetadataVersion.IBP_3_7_IV2,
- MetadataVersion.IBP_3_7_IV3
+ MetadataVersion.IBP_3_7_IV4,
+ MetadataVersion.IBP_3_8_IV0
Review Comment:
Notng that we are removing MetadataVersion.IBP_3_7_IV3 because it is
"burned" and will never be used.
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for KRaft.
IBP_3_7_IV2(17, "3.7", "IV2", true),
+ // IBP_3_7_IV3 was ELR related supports (KIP-966) and has been moved
forward
Review Comment:
I think we should keep the value and just not have anything associated with
it. Call it "reserved", similar to IBP_3_7_IV1. WDYT?
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -165,13 +165,15 @@ public void testFromVersionString() {
assertEquals(IBP_3_6_IV1,
MetadataVersion.fromVersionString("3.6-IV1"));
assertEquals(IBP_3_6_IV2,
MetadataVersion.fromVersionString("3.6-IV2"));
- // 3.7-IV0 is the latest production version in the 3.7 line
- assertEquals(IBP_3_7_IV0, MetadataVersion.fromVersionString("3.7"));
+ // 3.7-IV2 is the latest production version in the 3.7 line
+ assertEquals(IBP_3_7_IV2, MetadataVersion.fromVersionString("3.7"));
Review Comment:
Isn't it IBP_3_7_IV4?
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -228,6 +230,8 @@ public void testShortVersion() {
assertEquals("3.6", IBP_3_6_IV2.shortVersion());
assertEquals("3.7", IBP_3_7_IV0.shortVersion());
assertEquals("3.7", IBP_3_7_IV1.shortVersion());
+ assertEquals("3.7", IBP_3_7_IV2.shortVersion());
+ assertEquals("3.7", IBP_3_7_IV4.shortVersion());
Review Comment:
Keep IV3?
##########
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##########
@@ -274,7 +278,8 @@ public void testVersion() {
assertEquals("3.7-IV0", IBP_3_7_IV0.version());
assertEquals("3.7-IV1", IBP_3_7_IV1.version());
assertEquals("3.7-IV2", IBP_3_7_IV2.version());
- assertEquals("3.7-IV3", IBP_3_7_IV3.version());
Review Comment:
keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
