lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1426789748
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -429,21 +492,40 @@ public void onResponse(final ClientResponse response) {
long offset = offsetAndMetadata.offset();
Errors error = Errors.forCode(partition.errorCode());
if (error == Errors.NONE) {
- log.debug("OffsetCommit {} for partition {}", offset,
tp);
+ log.debug("OffsetCommit completed successfully for
offset {} partition {}", offset, tp);
continue;
}
- if (error == Errors.TOPIC_AUTHORIZATION_FAILED) {
+ if (error == Errors.COORDINATOR_NOT_AVAILABLE ||
+ error == Errors.NOT_COORDINATOR ||
+ error == Errors.REQUEST_TIMED_OUT) {
+
coordinatorRequestManager.markCoordinatorUnknown(error.message(),
currentTimeMs);
+ retry(currentTimeMs, error.exception());
+ return;
+ } else if (error == Errors.COORDINATOR_LOAD_IN_PROGRESS
+ || error == Errors.UNKNOWN_TOPIC_OR_PARTITION) {
+ // just retry
+ retry(currentTimeMs, error.exception());
+ return;
+ } else if (error == Errors.UNKNOWN_MEMBER_ID || error ==
Errors.STALE_MEMBER_EPOCH) {
Review Comment:
Agree, UNKNOWN_MEMBER_ID should end up failing the request.
STALE_MEMBER_EPOCH being the one that can be retried if the member got a new
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
