mumrah commented on code in PR #15007:
URL: https://github.com/apache/kafka/pull/15007#discussion_r1427975054
##########
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##########
@@ -645,6 +648,29 @@ public void run() throws Exception {
}
}
+ private BufferingBatchConsumer<ApiMessageAndVersion>
buildMigrationBatchConsumer(
+ MigrationManifest.Builder manifestBuilder
+ ) {
+ return new BufferingBatchConsumer<>(batch -> {
+ try {
+ if (log.isTraceEnabled()) {
+ batch.forEach(apiMessageAndVersion ->
+
log.trace(recordRedactor.toLoggableString(apiMessageAndVersion.message())));
+ }
+ CompletableFuture<?> future =
zkRecordConsumer.acceptBatch(batch);
+ long batchStart = time.nanoseconds();
+ FutureUtils.waitWithLogging(KRaftMigrationDriver.this.log, "",
Review Comment:
Thanks, the Flow API looks really cool. I'll check that out. Does look like
it's Java 9+ only, but I'll keep it in mind for future stuff (I think we'll be
bumping up to Java 11 for 4.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
