dajac commented on code in PR #14985: URL: https://github.com/apache/kafka/pull/14985#discussion_r1430672312
########## core/src/main/scala/kafka/server/KafkaApis.scala: ########## @@ -2416,14 +2419,56 @@ class KafkaApis(val requestChannel: RequestChannel, numAppends.decrementAndGet() skippedMarkers += 1 } else { - val controlRecords = partitionsWithCompatibleMessageFormat.map { partition => - val controlRecordType = marker.transactionResult match { - case TransactionResult.COMMIT => ControlRecordType.COMMIT - case TransactionResult.ABORT => ControlRecordType.ABORT + val controlRecordType = marker.transactionResult match { + case TransactionResult.COMMIT => ControlRecordType.COMMIT + case TransactionResult.ABORT => ControlRecordType.ABORT + } + + val markerResults = new ConcurrentHashMap[TopicPartition, Errors]() Review Comment: yep, it sounds right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org