satishd commented on code in PR #15026:
URL: https://github.com/apache/kafka/pull/15026#discussion_r1431232848
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -467,6 +480,12 @@ class BrokerTopicAggregatedMetric() {
partitionMetricValues.put(partition, partitionValue)
}
+ def incrementPartitionMetricValue(partition: Int): Unit =
partitionMetricValues.compute(partition, (_, value) => value + 1)
+
+
+ def decrementPartitionMetricValue(partition: Int): Unit =
partitionMetricValues.compute(partition, (_, value) => Math.max(0, value - 1))
Review Comment:
Can we remove this method also?
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -467,6 +480,12 @@ class BrokerTopicAggregatedMetric() {
partitionMetricValues.put(partition, partitionValue)
}
+ def incrementPartitionMetricValue(partition: Int): Unit =
partitionMetricValues.compute(partition, (_, value) => value + 1)
Review Comment:
Can we remove this method as it is not used anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
