lianetm commented on PR #14557: URL: https://github.com/apache/kafka/pull/14557#issuecomment-1863193316
Thanks for the comments @dajac , all addressed. I also included [2248b55](https://github.com/apache/kafka/pull/14557/commits/2248b55505a49c04868fd7b5807599d14a74df73) with a minor fix and tests. I created 2 follow up tasks that I will take right after this PR: - [KAFKA-16032](https://issues.apache.org/jira/browse/KAFKA-16032): To review and make error handling consistent for `OffsetFetch` and `OffsetCommit` - [KAFKA-16033](https://issues.apache.org/jira/browse/KAFKA-16033): To review the retry logic, considering moving it to the callers. This definitely aligns with the legacy coordinator approach, and would make the intentions clearer, but when considering it before seemed that it would lead to duplicated retry logic in callers that require similar retry, and seemed better to have the CommitMgr as single responsible of the retry logic based on the intention (params) of the caller. That was what led to the current approach, but I do get the trade-off, so I will take the 2 tasks in sync, attempt to unify/centralize the error handling in the commitMgr first, and re-evaluate the retry logic placement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
