divijvaidya commented on code in PR #15059:
URL: https://github.com/apache/kafka/pull/15059#discussion_r1434047673
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##########
@@ -319,40 +319,40 @@ public Long value() {
registry.newGauge(NUM_GENERIC_GROUPS_PREPARING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.PREPARING_REBALANCE);
+ return numGenericGroups(ClassicGroupState.PREPARING_REBALANCE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_COMPLETING_REBALANCE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return
numGenericGroups(GenericGroupState.COMPLETING_REBALANCE);
+ return
numGenericGroups(ClassicGroupState.COMPLETING_REBALANCE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_STABLE, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.STABLE);
+ return numGenericGroups(ClassicGroupState.STABLE);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_DEAD, new
com.yammer.metrics.core.Gauge<Long>() {
@Override
public Long value() {
- return numGenericGroups(GenericGroupState.DEAD);
+ return numGenericGroups(ClassicGroupState.DEAD);
}
});
registry.newGauge(NUM_GENERIC_GROUPS_EMPTY, new
com.yammer.metrics.core.Gauge<Long>() {
Review Comment:
Are we keeping the metrics name with "generic" keyword though? I think we
should if these metrics have already been released in previous versions, if
not, might want to change the metric names to "classic" as well.
e.g. GENERIC_GROUP_REBALANCES_SENSOR_NAME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
