divijvaidya commented on code in PR #14992:
URL: https://github.com/apache/kafka/pull/14992#discussion_r1434120692
##########
build.gradle:
##########
@@ -940,6 +940,7 @@ project(':core') {
implementation libs.jacksonModuleScala
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
+ implementation libs.jacksonAfterburner
Review Comment:
Please help me understand why did we add this dependency in clients?
##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -235,18 +235,24 @@ public Object toConnect(final Schema schema, final
JsonNode value) {
private final JsonDeserializer deserializer;
public JsonConverter() {
+ this(true);
+ }
+
+ public JsonConverter(boolean enableModules) {
serializer = new JsonSerializer(
- mkSet(),
- JSON_NODE_FACTORY
+ mkSet(),
Review Comment:
nit
please maintain original indentation
##########
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##########
@@ -235,18 +235,24 @@ public Object toConnect(final Schema schema, final
JsonNode value) {
private final JsonDeserializer deserializer;
public JsonConverter() {
+ this(true);
+ }
+
+ public JsonConverter(boolean enableModules) {
Review Comment:
please add a javadoc comment specifying that this ctor is visible only for
benchmarking. we add similar comments when we expose a new ctor/method for
testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
