agavra opened a new pull request, #15061:
URL: https://github.com/apache/kafka/pull/15061

   Before #14648, the `KStreamImplJoin` class would always create 
non-timestamped persistent windowed stores. After that PR, the default was 
changed to create timestamped stores. This wasn't compatible because, during 
restoration, timestamped stores have their values transformed to prepend the 
timestamp to the value. This caused serialization errors when trying to read 
from the store because the deserializers did not expect the timestamp to be 
prepended.
   
   To fix this, we allow creating non-timestamped stores using the 
`DslWindowParams`
   
   Testing was done both manually as well as adding a unit test to ensure that 
the stores created are not timestamped.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to