divijvaidya commented on PR #14867: URL: https://github.com/apache/kafka/pull/14867#issuecomment-1868586516
Hey @nizhikov @mimaison I this this PR may have broken a test since the test is failing in trunk 100% of the time after merging this PR. See: https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=trunk&search.timeZoneId=Europe%2FBerlin&tests.container=kafka.admin.ConfigCommandTest&tests.test=shouldNotSupportAlterClientMetricsWithZookeeper() <img width="876" alt="Screenshot 2023-12-24 at 20 57 51" src="https://github.com/apache/kafka/assets/71267/3cc0957d-c797-4967-b50c-8c616eda5482"> The failure message is: ``` org.opentest4j.AssertionFailedError: expected: <client-metrics is not a known entityType. Should be one of List(topics, clients, users, brokers, ips)> but was: <client-metrics is not a known entityType. Should be one of [topics, clients, users, brokers, ips]> ``` which is a result of have different toString() for ConfigType. Please fix this. I have created a JIRA - https://issues.apache.org/jira/browse/KAFKA-16048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org