showuon opened a new pull request, #15077:
URL: https://github.com/apache/kafka/pull/15077

   Following @dajac 's finding in https://github.com/apache/kafka/pull/15063, I 
found we also create new RemoteLogManager in ReplicaManagerTest, but didn't 
close them. 
   
   While investigating ReplicaManagerTest, I also found there are other threads 
leaking:
   1. remote fetch reaper thread. It's because we create a reaper thread in 
test, which is not expected. We should create a mocked one like other purgatory 
instance.
   2. Throttle threads. We created a `quotaManager` to feed into the 
replicaManager, but didn't close it. Actually, we have created a global 
`quotaManager` instance and will close it on `AfterEach`. We should re-use it.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to