vamossagar12 commented on PR #15072: URL: https://github.com/apache/kafka/pull/15072#issuecomment-1870244078
Thanks @divijvaidya , I think Ismael's point is correct. From what I recall, the streams final rule also expects the method arguements etc to be final as well (apart from local variables within methods). Enabling that rule would be a big change I guess. Also, I see only variables and parameters [here](https://checkstyle.sourceforge.io/checks/coding/finallocalvariable.html#FinalLocalVariable) for tokens to check. I think we can leave it to this but the only problem is, there won't be any such enforcements for using final variables and might need cleanups in the future. That should be ok IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
