showuon commented on code in PR #15093:
URL: https://github.com/apache/kafka/pull/15093#discussion_r1439274938
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2410,8 +2413,8 @@ class KafkaApisTest {
responseCallback.capture(),
ArgumentMatchers.eq(requestLocal)
)).thenAnswer(_ =>
responseCallback.getValue.apply(Errors.PRODUCER_FENCED))
-
- createKafkaApis().handleEndTxnRequest(request, requestLocal)
+ kafkaApis = createKafkaApis()
+ kafkaApis.handleEndTxnRequest(request, requestLocal)
Review Comment:
here, and some places below.
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2055,8 +2058,8 @@ class KafkaApisTest {
responseCallback.capture(),
ArgumentMatchers.eq(requestLocal)
)).thenAnswer(_ =>
responseCallback.getValue.apply(InitProducerIdResult(producerId, epoch,
Errors.PRODUCER_FENCED)))
-
- createKafkaApis().handleInitProducerIdRequest(request, requestLocal)
+ kafkaApis = createKafkaApis()
+ kafkaApis.handleInitProducerIdRequest(request, requestLocal)
Review Comment:
Does the intent correct?
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2167,8 +2170,8 @@ class KafkaApisTest {
responseCallback.capture(),
ArgumentMatchers.eq(requestLocal)
)).thenAnswer(_ =>
responseCallback.getValue.apply(Errors.PRODUCER_FENCED))
-
- createKafkaApis().handleAddPartitionsToTxnRequest(request, requestLocal)
+ kafkaApis = createKafkaApis()
+ kafkaApis.handleAddPartitionsToTxnRequest(request, requestLocal)
Review Comment:
ditto
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -2113,8 +2116,8 @@ class KafkaApisTest {
responseCallback.capture(),
ArgumentMatchers.eq(requestLocal)
)).thenAnswer(_ =>
responseCallback.getValue.apply(Errors.PRODUCER_FENCED))
-
- createKafkaApis().handleAddOffsetsToTxnRequest(request, requestLocal)
+ kafkaApis = createKafkaApis()
+ kafkaApis.handleAddOffsetsToTxnRequest(request, requestLocal)
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
