tinaselenge commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1439373207
##########
clients/src/test/java/org/apache/kafka/common/config/provider/DirectoryConfigProviderTest.java:
##########
@@ -83,27 +89,27 @@ public void close() throws IOException {
@Test
public void testGetAllKeysAtPath() {
- ConfigData configData = provider.get(dir.getAbsolutePath());
Review Comment:
This was resulted by using `java.nio.file.Files` instead of `File` therefore
no longer can call getAbsolutePath() to pass in a string argument. The test
variables types are changed to String, to avoid having to do string
conversation everywhere. I didn't think changing test variable types would
break the compatibility, since the we are still passing the same type of
variable to the calling method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
