jolshan commented on code in PR #15087:
URL: https://github.com/apache/kafka/pull/15087#discussion_r1441068240
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -749,9 +749,11 @@ class ReplicaManager(val config: KafkaConfig,
* @param responseCallback callback for sending the response
* @param delayedProduceLock lock for the delayed actions
* @param recordValidationStatsCallback callback for updating stats on
record conversions
- * @param requestLocal container for the stateful instances
scoped to this request
- * @param transactionalId transactional ID if the request is
from a producer and the producer is transactional
+ * @param requestLocal container for the stateful instances
scoped to this request -- this must correspond to the
+ * thread calling this method
* @param actionQueue the action queue to use.
ReplicaManager#defaultActionQueue is used by default.
+ * @param verificationGuards the mapping from topic partition to
verification guards if transaction verification is used
+ * @param preAppendErrors the mapping from topic partition to
LogAppendResult for errors that occurred before appending
Review Comment:
Oh I see what you are saying -- basically the appendCallback should be
defined so the verification errors are joined whenever the callback is defined
(ideally after we get the verification errors).
So the callback for verification would include the definition of the append
callback. I think this could work.
Time to change all the mock code 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
