clolov commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1443172726


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -4904,7 +4870,8 @@ public void suspend() {
         final Map<TaskId, Set<TopicPartition>> assignment = new 
HashMap<>(taskId00Assignment);
         assignment.putAll(taskId01Assignment);
         when(activeTaskCreator.createTasks(any(), 
Mockito.eq(assignment))).thenReturn(asList(task00, task01));
-        replay(consumer);
+
+        taskManager.setMainConsumer(mockitoConsumer);

Review Comment:
   Yes, we are using the old consumer in all places making calls to
   ```
       private static void expectConsumerAssignmentPaused(final 
Consumer<byte[], byte[]> consumer) {
           final Set<TopicPartition> assignment = singleton(new 
TopicPartition("assignment", 0));
           expect(consumer.assignment()).andReturn(assignment);
           consumer.pause(assignment);
       }
   ```
   This is also why I took the approach of having a separate Mockito consumer. 
Part 2 of this pull request will migrate all of those usages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to