kamalcph commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1880409444
The proposed patch LGTM. Here, the "all-topic" metric value refers to per-broker level aggregate. Is this correct? Can we have a Jconsole screenshot of the metrics? I'll also build one locally and verify it: > The metrics added in KIP-963 is BrokerTopicMetrics, which means it should provide per-topic metric value and all topics metric value. But current implementation doesn't update all topic metric value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
