gaurav-narula commented on code in PR #15136:
URL: https://github.com/apache/kafka/pull/15136#discussion_r1444469837
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2773,6 +2776,12 @@ class ReplicaManager(val config: KafkaConfig,
Some(partition, false)
case HostedPartition.None =>
+ var isNew = true
Review Comment:
I don't think that would work because `isNew` is mutated inside the callback
which may be executed conditionally.
Edit: Perhaps I can have `maybeRecoverAbandonedFutureLog` return a boolean
instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
