nizhikov commented on PR #14871:
URL: https://github.com/apache/kafka/pull/14871#issuecomment-1881211127
@mimaison @ijuma Guys, I need your advice here.
`ConfigCommand` code are tightly coupled with other part of `core` module.
In this PR I tried to move one of dependency - `DynamicConfig` to
`server-commons`.
There still one method that not moved:
```
object Broker {
DynamicBrokerConfig.addDynamicConfigs(BROKER_CONFIG_DEF)
val nonDynamicProps = KafkaConfig.configNames.toSet --
BROKER_CONFIG_DEF.names.asScala
}
```
dependencies are `DynamicConfig` -> `DynamicBrokerConfig` -> `KafkaConfig`,
etc.
Can you, please, advice me - should I continue and try move all chain to
java?
I can try to make separate PR with moving `KafkaConfig` and other classes.
Or is it too much for now and I must go other way for these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
