jolshan commented on code in PR #15142:
URL: https://github.com/apache/kafka/pull/15142#discussion_r1445431424
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/PartitionWriter.java:
##########
@@ -116,4 +120,21 @@ long appendEndTransactionMarker(
int coordinatorEpoch,
TransactionResult result
) throws KafkaException;
+
+ /**
+ * Verify the transaction.
+ *
+ * @param tp The partition to write records to.
+ * @param transactionalId The transactional id.
+ * @param producerId The producer id.
+ * @param producerEpoch The producer epoch.
+ * @return A future containing the {@link VerificationGuard} or an
exception.
Review Comment:
nit: we could have a verification guard without verifying the transaction --
(how the method in ReplicaManager works) so maybe we should include that we
only return the verification guard and not an error if it was verified by the
transaction coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
