mjsax commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1446048966
########## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ########## @@ -111,5 +116,20 @@ public void testValidateIntervalMsInvalid(int pushIntervalMs) { public void testPreferredCompressionType() { assertEquals(CompressionType.NONE, ClientTelemetryUtils.preferredCompressionType(Collections.emptyList())); assertEquals(CompressionType.NONE, ClientTelemetryUtils.preferredCompressionType(null)); + assertEquals(CompressionType.NONE, ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.NONE, CompressionType.GZIP))); + assertEquals(CompressionType.GZIP, ClientTelemetryUtils.preferredCompressionType(Arrays.asList(CompressionType.GZIP, CompressionType.NONE))); + } + + @ParameterizedTest + @EnumSource(CompressionType.class) + public void testCompressDecompress(CompressionType compressionType) { + byte[] testString = "test string".getBytes(StandardCharsets.UTF_8); + ByteBuffer compressed = ClientTelemetryUtils.compress(testString, compressionType); + assertNotNull(compressed); Review Comment: Should we check if array length was reduced? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org