DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824091
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -353,7 +358,8 @@ class BrokerServer(
dynamicConfigHandlers = Map[String, ConfigHandler](
ConfigType.TOPIC -> new TopicConfigHandler(replicaManager, config,
quotaManagers, None),
ConfigType.BROKER -> new BrokerConfigHandler(config, quotaManagers),
- ConfigType.CLIENT_METRICS -> new
ClientMetricsConfigHandler(clientMetricsManager))
+ ConfigType.CLIENT_METRICS -> new
ClientMetricsConfigHandler(clientMetricsManager),
+ ConfigType.GROUP -> new
ConsumerGroupConfigHandler(consumerGroupConfigManager))
Review Comment:
Done
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -264,3 +265,12 @@ class ClientMetricsConfigHandler(private val
clientMetricsManager: ClientMetrics
clientMetricsManager.updateSubscription(subscriptionGroupId, properties)
}
}
+
+/**
+ * The GroupConfigHandler will process individual group config changes in ZK.
+ */
+class ConsumerGroupConfigHandler(private val consumerGroupConfigManager:
ConsumerGroupConfigManager) extends ConfigHandler with Logging {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
