gharris1727 commented on code in PR #15154:
URL: https://github.com/apache/kafka/pull/15154#discussion_r1450911725
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java:
##########
@@ -75,9 +77,9 @@ public class ErrorHandlingIntegrationTest {
private static final String DLQ_TOPIC = "my-connector-errors";
private static final String CONNECTOR_NAME = "error-conn";
private static final String TASK_ID = "error-conn-0";
- private static final int NUM_RECORDS_PRODUCED = 20;
- private static final int EXPECTED_CORRECT_RECORDS = 19;
+ private static final int NUM_RECORDS_PRODUCED = 1000;
private static final int EXPECTED_INCORRECT_RECORDS = 1;
+ private static final int EXPECTED_CORRECT_RECORDS = NUM_RECORDS_PRODUCED -
EXPECTED_INCORRECT_RECORDS;
Review Comment:
Good catch, this test had the same flaw in two places, and I already fixed
the other one. I think one test was copied from the other in this class, and
these situational constants were used incorretly. I changed the constants so
that the failure count is clearly relevant to the FaultyPassthrough, and may be
less likely to be copied in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
