satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284748


##########
core/src/main/scala/kafka/log/LogCleaner.scala:
##########
@@ -1245,8 +1246,8 @@ private[log] class CleanedTransactionMetadata {
    *
    * @param abortedTransactions The new found aborted transactions to add
    */
-  def addAbortedTransactions(abortedTransactions: List[AbortedTxn]): Unit = {
-    this.abortedTransactions ++= abortedTransactions
+  def addAbortedTransactions(abortedTransactions: util.List[AbortedTxn]): Unit 
= {
+    abortedTransactions.forEach(abortedTxn => this.abortedTransactions += 
abortedTxn)

Review Comment:
   Wanted to avoid scala conversion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to