[
https://issues.apache.org/jira/browse/KAFKA-3881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531999#comment-16531999
]
raghavan chockalingam commented on KAFKA-3881:
----------------------------------------------
This pull request is open since June 2017. Is this requirement still valid?
I believe you meant the {{MetricName}} should be agnostic of the name format
that a particular metric platform / repository might require such as Graphite.
An implementation of {{MetricsReporter}} should be able to convert
{{MetricName}} appropriately so that the metric is reported as intended in a
metric platform.
> Remove the replacing logic from "." to "_" in Fetcher
> -----------------------------------------------------
>
> Key: KAFKA-3881
> URL: https://issues.apache.org/jira/browse/KAFKA-3881
> Project: Kafka
> Issue Type: Bug
> Components: consumer, metrics
> Reporter: Guozhang Wang
> Assignee: Tom Bentley
> Priority: Major
> Labels: newbie, patch-available
>
> The logic of replacing "." to "_" in metrics names / tags was originally
> introduced in the core package's metrics since Graphite treats "." as
> hierarchy separators (see KAFKA-1902); for the client metrics, it is supposed
> that the GraphiteReported should take care of this itself rather than letting
> Kafka metrics to special handle for it. In addition, right now only consumer
> Fetcher had replace, but producer Sender does not have it actually.
> So we should consider removing this logic in the consumer Fetcher's metrics
> package. NOTE that this is a public API backward incompatible change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
