Owen-CH-Leung commented on code in PR #13909: URL: https://github.com/apache/kafka/pull/13909#discussion_r1451645916
########## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ########## @@ -1263,6 +1327,8 @@ protected String getConfigValue(ConfigKey key, String headerName) { return key.type.toString().toLowerCase(Locale.ROOT); case "Default": if (key.hasDefault()) { + if (key.alternativeString != null) Review Comment: @mjsax Thanks a lot for your comment. I've removed the constructor and modified the existing constructor to include `alternativeString` (And also changes the caller that didn't set it). Also I remove the `key.alternativeString` check in `getConfigValue` and put it into `toHtml` instead. Let me know what you think =) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org