Re: [PR] [Kafka-14404] fix overlap of streams-config sections & describe additional parameters [kafka]

[via GitHub]

AyoubOm commented on code in PR #15162:
URL: https://github.com/apache/kafka/pull/15162#discussion_r1452182174


##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -1111,28 +1111,31 @@ <h4><a class="toc-backref" href="#id18">Default 
Values</a><a class="headerlink"
           <td>Consumer</td>
           <td>earliest</td>
         </tr>
-        <tr class="row-even"><td>linger.ms</td>
+        <tr class="row-odd"><td>linger.ms</td>
           <td>Producer</td>
           <td>100</td>
         </tr>
         <tr class="row-even"><td>max.poll.records</td>
           <td>Consumer</td>
           <td>1000</td>
         </tr>
+        <tr class="row-odd">
+          <td>transaction.timeout.ms</td>
+          <td>Producer</td>
+          <td><code class="docutils literal"><span 
class="pre">10000</span></code></td>
+        </tr>
+        <tr class="row-even">
+          <td>client.id</td>
+          <td>-</td>
+          <td><code class="docutils literal"><span 
class="pre">&lt;application.id&gt;-&lt;random-UUID&gt;</span></code></td>
+        </tr>
         </tbody>
       </table>
     </div>
     <div class="section" id="parameters-controlled-by-kafka-streams">
       <h3><a class="toc-backref" href="#id26">Parameters controlled by Kafka 
Streams</a><a class="headerlink" href="#parameters-controlled-by-kafka-streams" 
title="Permalink to this headline"></a></h3>
-      <p>Kafka Streams assigns the following configuration parameters. If you 
try to change
-        <code class="docutils literal"><span 
class="pre">allow.auto.create.topics</span></code>, your value
-        is ignored and setting it has no effect in a Kafka Streams 
application. You can set the other parameters.
-        Kafka Streams sets them to different default values than a plain
-        <code class="docutils literal"><span 
class="pre">KafkaConsumer</span></code>.
-      <p>Kafka Streams uses the <code class="docutils literal"><span 
class="pre">client.id</span></code>
-        parameter to compute derived client IDs for internal clients. If you 
don't set
-        <code class="docutils literal"><span 
class="pre">client.id</span></code>, Kafka Streams sets it to
-        <code class="docutils literal"><span 
class="pre">&lt;application.id&gt;-&lt;random-UUID&gt;</span></code>.
+      <p>Some parameters are not configurable by the user. If you supply a 
value that is different from the default value,
+        your value is ignored. Below is a list of some of these parameters.

Review Comment:
   Added `isolation.level` and `enable.idempotence` in a separate table. Is it 
fine ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org