ppatierno commented on PR #15193:
URL: https://github.com/apache/kafka/pull/15193#issuecomment-1893250162

   @cmccabe I didn't get what you say ... maybe I wasn't clear. Let me add more 
details and questions.
   
   The rollback documentation should be clearer about the steps to do and the 
configuration parameters to add/remove.
   We already have something like that for the migration, where everything is 
explained in details. I think we should have the same for rollback (and not 
just mentioning a `ZK mode`).
   Also, my expectation is that a user can rollback to ZooKeeper when the 
cluster is in "dual write" mode. I mean, you start migration (following the 
doc), you end in "dual write" but, because of any reasons, you decide to 
rollback to ZooKeeper instead of finalizing the migration and move to full 
KRaft.
   When you are in "dual write", these are the configuration parameters you end 
up with on a broker (as per migration doc):
   
   ```shell
   # Enable the migration
   zookeeper.metadata.migration.enable=true
   
   # ZooKeeper client configuration
   zookeeper.connect=localhost:2181
   
   # KRaft controller quorum configuration
   controller.quorum.voters=3000@localhost:9093
   controller.listener.names=CONTROLLER
   ```
   
   So referring to my comment in the PR, there is no process.roles to remove or 
zookeeper.connect to re-add because they are already there.
   You also said to not remove the controller(s) configuration part, so what 
should a user do from here? Not removing migration flag, not removing 
controller(s) parameters, so what?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to