lucasbru commented on code in PR #15219:
URL: https://github.com/apache/kafka/pull/15219#discussion_r1457110433


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##########
@@ -146,7 +146,7 @@ public static <R> QueryResult<R> handleBasicQueries(
                 "Handled in " + store.getClass() + " in " + (System.nanoTime() 
- start) + "ns"
             );
         }
-        result.setPosition(position);
+        result.setPosition(position.copy());

Review Comment:
   Nice find! But I'm not sure, whether this thread safe now? It seems I'd have 
to put a lock somewhere to make sure `position` isn't modified before I reach 
this point. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to