philipnee commented on code in PR #15210:
URL: https://github.com/apache/kafka/pull/15210#discussion_r1457711259
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##########
@@ -1547,6 +1553,29 @@ public String toString() {
}
}
+ private class ConsumerCoordinatorMetrics {
Review Comment:
I split the implementation into two classes because there's no need to pass
the ref of this entire object to the request manager just for the commitSensor
(see addCommitSensor method). Instead, I think it would be a lot easier to
pass the Metrics object to the manager and create their own sensors
(essentially these metrics objects just hold a bunch of sensors referenced from
Metrics).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
