apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1457900006
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1140,9 +1141,9 @@ private[kafka] class Processor(
expiredConnectionsKilledCount.record(null, 1, 0)
} else {
val connectionId = receive.source
- val context = new RequestContext(header, connectionId,
channel.socketAddress,
- channel.principal, listenerName, securityProtocol,
- channel.channelMetadataRegistry.clientInformation,
isPrivilegedListener, channel.principalSerde)
+ val context = new RequestContext(header, connectionId,
channel.socketAddress, Optional.of(channel.socketPort()),
Review Comment:
I find RequestContext is either created in SocketServer or during forwarding
requests. We currently don't require client port information outside KIP-714,
push telemetry request is not marked forwardable, wiring the client port
information elsewhere seems not useful at this point of time hence I marked it
as Optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
