kirktrue commented on code in PR #15186:
URL: https://github.com/apache/kafka/pull/15186#discussion_r1462623131


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -376,25 +376,21 @@ protected Map<Node, FetchSessionHandler.FetchRequestData> 
prepareCloseFetchSessi
         final Cluster cluster = metadata.fetch();

Review Comment:
   I made the `closeInternal()` method `synchronized` as that more closely 
emulates the synchronization in <= 3.5. It covers 
`prepareCloseFetchSessionRequests()` too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to