hachikuji commented on code in PR #15231: URL: https://github.com/apache/kafka/pull/15231#discussion_r1463806130
########## clients/src/main/resources/common/message/VoteRequest.json: ########## @@ -18,7 +18,8 @@ "type": "request", "listeners": ["controller"], "name": "VoteRequest", - "validVersions": "0", + // Version 1 adds the PreVote field and renames CandidateEpoch and CandidateId to ReplicaEpoch and ReplicaId Review Comment: Agree it would be better to implement all of it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
