mimaison commented on PR #15260: URL: https://github.com/apache/kafka/pull/15260#issuecomment-1910237310
I agree we want to shift `Defaults` into `KafkaConfig` (in Java) but I wonder if we should keep what we have for now and keep breaking the Scala `KafkaConfig` down. It seems the bulk of this PR is basically refactoring the Scala `KafkaConfig` which we aim to remove, and causes a bunch of changes (for example the `KafkaConfig -> JKafkaConfig`) that will need to be updated again once `KafkaConfig` is fully moved. It seems we have most of the remaining changes needed to fully move `KafkaConfig` ready so I wonder if we should keep working on them and merge `Defaults/KafkaConfig` when we finally remove the Scala version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
