gaurav-narula commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1911962461
> I think the impact of this bug is that if there are more than 1 log dirs in ZK broker, and when the 1st of them is failed, we will shutdown the broker unexpectedly. But if there's only 1 log dir, it should be fine to shutdown the broker since no available online log dir. (just have a strange log saying _Shutdown broker because the metadata log dir_. Is my understanding correct? > > If so, I think the change makes sense. Could you add tests for it? That's correct. The case where all log directories fail is handled in `logManager.handleLogDirFailure` which is invoked on line 2588. Will follow up with a test shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
