pprovenzano commented on code in PR #15270:
URL: https://github.com/apache/kafka/pull/15270#discussion_r1469044374
##########
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##########
@@ -166,6 +169,11 @@ class BrokerMetadataPublisher(
Option(delta.featuresDelta()).foreach { featuresDelta =>
featuresDelta.metadataVersionChange().ifPresent{ metadataVersion =>
info(s"Updating metadata.version to
${metadataVersion.featureLevel()} at offset $highestOffsetAndEpoch.")
+ if (currentMetadataVersion.isLessThan(MetadataVersion.IBP_3_7_IV2)
&& metadataVersion.isAtLeast(MetadataVersion.IBP_3_7_IV2)) {
+ info("Resending BrokerRegistration with existing incarnation-id to
inform the " +
+ "controller about log directories in the broker following
metadata update")
+ brokerLifecycleManager.handleKraftJBODMetadataVersionUpdate()
+ }
}
Review Comment:
Yes, I like it that we will update this always going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
