DL1231 commented on code in PR #15211:
URL: https://github.com/apache/kafka/pull/15211#discussion_r1469457414
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -67,14 +68,22 @@ public enum ConsumerGroupState {
private final String name;
+ private final String capitalizedName;
Review Comment:
Done.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##########
@@ -956,6 +956,20 @@ public Optional<OffsetExpirationCondition>
offsetExpirationCondition() {
return Optional.empty();
}
+ /**
+ * The state of this group.
+ *
+ * @return The current state as a lowercase String.
+ */
+ public String stateAsLowerCaseString() {
+ return this.state.toLowerCaseString();
+ }
+
+ @Override
+ public boolean isInStates(Set<String> statesFilter, long committedOffset) {
+ return statesFilter.contains(this.stateAsLowerCaseString()) ||
statesFilter.contains(this.stateAsString());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
