philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1470058217
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/KafkaConsumerMetrics.java:
##########
@@ -26,20 +26,20 @@
import java.util.concurrent.TimeUnit;
-public class KafkaConsumerMetrics implements AutoCloseable {
+import static
org.apache.kafka.clients.consumer.internals.metrics.AbstractConsumerMetricsManager.MetricGroupSuffix.CONSUMER;
+
+public class KafkaConsumerMetrics extends AbstractConsumerMetricsManager
implements AutoCloseable {
private final MetricName lastPollMetricName;
private final Sensor timeBetweenPollSensor;
private final Sensor pollIdleSensor;
private final Sensor committedSensor;
private final Sensor commitSyncSensor;
- private final Metrics metrics;
private long lastPollMs;
private long pollStartMs;
private long timeSinceLastPollMs;
public KafkaConsumerMetrics(Metrics metrics, String metricGrpPrefix) {
Review Comment:
i'm not even sure why we have metricGrpPrefix from the beginning - it is not
specified by the user and it seems to always be the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
