jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470098563
########## core/src/main/scala/kafka/server/ReplicaManager.scala: ########## @@ -982,24 +996,21 @@ class ReplicaManager(val config: KafkaConfig, producerId: Long, producerEpoch: Short, baseSequence: Int, - requestLocal: RequestLocal, - callback: (Errors, RequestLocal, VerificationGuard) => Unit + callback: ((Errors, VerificationGuard)) => Unit ): Unit = { - def generalizedCallback(preAppendErrors: Map[TopicPartition, Errors], - newRequestLocal: RequestLocal, - verificationGuards: Map[TopicPartition, VerificationGuard]): Unit = { - callback( + def generalizedCallback(results: (Map[TopicPartition, Errors], Map[TopicPartition, VerificationGuard])): Unit = { + val (preAppendErrors, verificationGuards) = results + callback(( Review Comment: nit: are the double `((` needed? I see it elsewhere so maybe I'm missing an aspect of the language. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org