nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473126369
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1374,7 +1376,7 @@ public void signalResume() {
*/
int maybeCommit() {
final int committed;
- if (now - lastCommitMs > commitTimeMs) {
+ if (taskManager.needsCommit(true) || now - lastCommitMs >
commitTimeMs) {
Review Comment:
I've added a test for this in 0577905, but it feels like a bit of a
tautology: it essentially just tests that `commit()` is called when
`taskManager.needsCommit(anyBoolean())` returns `true`.
The real meat of this will be in the `TaskManagerTests`, which I'm working
on separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
